Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-23166] Add resize flag to document list with option to disable blur #9090

Merged

Conversation

MichalKinas
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Added resize option to document list and option to disable blur when resizing. https://alfresco.atlassian.net/browse/MNT-23166

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@AleksanderSklorz
Copy link
Contributor

AleksanderSklorz commented Nov 15, 2023

@MichalKinas one question - did you test this how it works with "Tags" column? Actually this column behaves like:

  • it displays only one row of tags, if there is more tags it displays only these which fit and rest are visible after click on "View x more" button,
  • that behavior is dynamic - if you resize window then available width of column is recalculated and proper number of tags are displayed

Is that behavior preserved after these changes? It should also recalculate available space for Tags when resize columns I guess.

@MichalKinas
Copy link
Contributor Author

@MichalKinas one question - did you test this how it works with "Tags" column? Actually this column behaves like:

  • it displays only one row of tags, if there is more tags it displays only these which fit and rest are visible after click on "View x more" button,
  • that behavior is dynamic - if you resize window then available width of column is recalculated and proper number of tags are displayed

Is that behavior preserved after these changes? It should also recalculate available space for Tags when resize columns I guess.

Yes I did, it works as expected, each time any column is resized tags column also recalculates how it should be displayed

@MichalKinas MichalKinas force-pushed the MNT-23166-make-columns-in-display-panes-resizable-in-adw branch from 3fea24e to b493d41 Compare November 15, 2023 12:18
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@MichalKinas MichalKinas merged commit 81787d5 into develop Nov 15, 2023
32 checks passed
@MichalKinas MichalKinas deleted the MNT-23166-make-columns-in-display-panes-resizable-in-adw branch November 15, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants