Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PRODENG-211] integrate JS-API with monorepo (part 1) #9081

Merged
merged 37 commits into from
Nov 21, 2023
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Nov 10, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

integrate JS-API project into the monorepo

  • build (nx build js-api)
  • lint (nx lint js-api)
  • test (nx test js-api upload suite disabled and needs investigations)
  • integrate with GHA unit testing
  • publish to npm
  • update scripts/update-version.sh
  • update scripts/github/build/npm-check-bundles.sh
  • review the Sonar Cloud report and fix what's possible
  • tsconfig paths for other libs
  • remove JS-API upstream GH worfklow and corresponding scripts
  • switch to node.js assert instead of chai where posible
    • remove @types/chai
    • remove @types/chai-spies
    • remove chai
    • remove chai-spies

After the merge of part 1:

  • review the upstream adf on apps
  • ensure the lib is published to GitHub package registry

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/PRODENG-211
https://alfresco.atlassian.net/browse/ACS-6231

@DenysVuika DenysVuika marked this pull request as ready for review November 14, 2023 09:12
@DenysVuika DenysVuika changed the title [PRODENG-211] integrate JS-API with monorepo [PRODENG-211] integrate JS-API with monorepo (part 1) Nov 14, 2023
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot B 2 Security Hotspots
Code Smell A 115 Code Smells

No Coverage information No Coverage information
3.3% 3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Contributor

@mauriziovitale mauriziovitale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure the code is up to date with the latest commit on the js api

@DenysVuika DenysVuika merged commit ea2c0ce into develop Nov 21, 2023
32 of 33 checks passed
@DenysVuika DenysVuika deleted the js-api branch November 21, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants