Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protractor cleanup for demo shell #9019

Merged
merged 23 commits into from
Oct 27, 2023
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Oct 24, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • Cleanup all "synthetic" tests in protractor, i.e. those addressing the demo shell implementation rather than real-life scenarios
  • cleanup dead code
  • remove custom fonts from the demo shell
  • remove various Viewer customisations in demo shell
  • remove site picker from document list demo (not used)
  • cleanup various css styles in demo shell

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@DenysVuika DenysVuika force-pushed the protractor-demo-shell-cleanup branch from 4ad4ecd to 5413869 Compare October 27, 2023 15:06
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 620911c into develop Oct 27, 2023
33 checks passed
@DenysVuika DenysVuika deleted the protractor-demo-shell-cleanup branch October 27, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants