Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-5645] Property Panel Feature #8995

Merged
merged 204 commits into from
Dec 21, 2023
Merged

Conversation

AnukritiGL
Copy link
Contributor

@AnukritiGL AnukritiGL commented Oct 13, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Our current behavior is to have only one edit button which can be used to edit all panels when clicked.
The design of the Property Panel appears outdated, and the title in the InfoDrawer is generic, labeled as "Details."

What is the new behaviour?
The Property Panel design has been revamped for both small and large screens. Additionally, the InfoDrawer now displays file titles with accompanying icons instead of the generic label "Details."

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-5645

Based on requirements, we've added some new features:

Edit Icon Button: We've added an 'Edit' icon button on each panel. When click this button on a specific panel, that panel becomes editable, allowing you to make changes to its content.
Edit and Clear Button: As per design edit and clear button has been removed from the property panel fields.

Save and Discard Icons: Once you click the 'Edit' button and make changes to a panel, you'll notice two new icons within that panel: 'Save' and 'Discard.' The 'Save' icon lets you save the changes you've made, while the 'Discard' icon allows you to abandon any unsaved modifications and revert to the original content.

Improved Styles: We've also worked on the styles of property panel. The tags and category panels now have a more appealing look, tailored to match figma design.

Expansion Indicator: we've added expansion indicators to the panel headers.

Edit Button Functionality for Aspect Panel: We've implemented an 'Edit' button functionality for the Aspect Panel as well. Similar to the other panels, clicking this button will enable you to edit the content within the Aspect Panel.

Improved Panel Visibility: we have made significant improvements to the overall layout. Now, all panels are visible without the need for any additional buttons like 'More Information' or 'Less Information.

Title and Icon in property Panel: In the collapsed and expanded mode now displays file titles with accompanying icons instead of the generic label "Details."

Dependent PR's:
ACA: Alfresco/alfresco-content-app#3477
ADW: https://github.com/Alfresco/alfresco-applications/pull/459

ui-property.webm

@AnukritiGL AnukritiGL force-pushed the ACS-5645-property-panel-feature branch from 0c03e2e to b8fb235 Compare October 16, 2023 10:30
@rbahirsheth rbahirsheth marked this pull request as ready for review October 16, 2023 12:03
@AnukritiGL AnukritiGL force-pushed the ACS-5645-property-panel-feature branch from b8fb235 to 52ad6e8 Compare October 17, 2023 06:50
Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More review comments will be added when we will be able to test it with ACA

docs/tutorials/content-metadata-component.md Outdated Show resolved Hide resolved
docs/tutorials/content-metadata-component.md Outdated Show resolved Hide resolved
docs/tutorials/content-metadata-component.md Outdated Show resolved Hide resolved
docs/tutorials/content-metadata-component.md Outdated Show resolved Hide resolved
docs/tutorials/content-metadata-component.md Outdated Show resolved Hide resolved
lib/content-services/src/lib/i18n/en.json Outdated Show resolved Hide resolved
lib/core/src/lib/i18n/en.json Show resolved Hide resolved
Copy link
Contributor

@DenysVuika DenysVuika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still some concerns about implementation, no actions needed as I'm reworking the PR

@DenysVuika DenysVuika self-assigned this Oct 21, 2023
@Alfresco Alfresco deleted a comment from sonarqubecloud bot Oct 21, 2023
@rbahirsheth rbahirsheth force-pushed the ACS-5645-property-panel-feature branch from 7193256 to d17f9c2 Compare December 21, 2023 08:14
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.5% Duplication on New Code

See analysis details on SonarCloud

@BSekula
Copy link
Contributor

BSekula commented Dec 21, 2023

There is one issue with e2es after removing .adf-textitem-clear-icon

Nevertheless after discussing the @rbahirsheth this icon was removed, therefore we can align this e2e

@rbahirsheth rbahirsheth merged commit a900dd2 into develop Dec 21, 2023
33 checks passed
@rbahirsheth rbahirsheth deleted the ACS-5645-property-panel-feature branch December 21, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants