-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-5645] Property Panel Feature #8995
Conversation
...-services/src/lib/content-metadata/components/content-metadata/content-metadata.component.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tags-creator/tags-creator.component.ts
Outdated
Show resolved
Hide resolved
0c03e2e
to
b8fb235
Compare
b8fb235
to
52ad6e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More review comments will be added when we will be able to test it with ACA
lib/content-services/src/lib/tag/tags-creator/tags-creator.component.scss
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts
Outdated
Show resolved
Hide resolved
401701a
to
5250aa3
Compare
0c754f7
to
ecacaf7
Compare
cb3e852
to
7188113
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still some concerns about implementation, no actions needed as I'm reworking the PR
lib/core/src/lib/card-view/components/card-view-dateitem/card-view-dateitem.component.html
Show resolved
Hide resolved
...tent-services/src/lib/category/categories-management/categories-management.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/core/src/lib/card-view/components/card-view-textitem/card-view-textitem.component.spec.ts
Outdated
Show resolved
Hide resolved
...ore/src/lib/card-view/components/card-view-selectitem/card-view-selectitem.component.spec.ts
Outdated
Show resolved
Hide resolved
...ore/src/lib/card-view/components/card-view-selectitem/card-view-selectitem.component.spec.ts
Outdated
Show resolved
Hide resolved
lib/content-services/src/lib/tag/tags-creator/tags-creator.component.spec.ts
Outdated
Show resolved
Hide resolved
demo-shell/src/app/components/file-view/file-view.component.html
Outdated
Show resolved
Hide resolved
demo-shell/src/app/components/file-view/file-view.component.html
Outdated
Show resolved
Hide resolved
7193256
to
d17f9c2
Compare
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
There is one issue with e2es after removing Nevertheless after discussing the @rbahirsheth this icon was removed, therefore we can align this e2e |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Our current behavior is to have only one edit button which can be used to edit all panels when clicked.
The design of the Property Panel appears outdated, and the title in the InfoDrawer is generic, labeled as "Details."
What is the new behaviour?
The Property Panel design has been revamped for both small and large screens. Additionally, the InfoDrawer now displays file titles with accompanying icons instead of the generic label "Details."
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-5645
Based on requirements, we've added some new features:
Edit Icon Button: We've added an 'Edit' icon button on each panel. When click this button on a specific panel, that panel becomes editable, allowing you to make changes to its content.
Edit and Clear Button: As per design edit and clear button has been removed from the property panel fields.
Save and Discard Icons: Once you click the 'Edit' button and make changes to a panel, you'll notice two new icons within that panel: 'Save' and 'Discard.' The 'Save' icon lets you save the changes you've made, while the 'Discard' icon allows you to abandon any unsaved modifications and revert to the original content.
Improved Styles: We've also worked on the styles of property panel. The tags and category panels now have a more appealing look, tailored to match figma design.
Expansion Indicator: we've added expansion indicators to the panel headers.
Edit Button Functionality for Aspect Panel: We've implemented an 'Edit' button functionality for the Aspect Panel as well. Similar to the other panels, clicking this button will enable you to edit the content within the Aspect Panel.
Improved Panel Visibility: we have made significant improvements to the overall layout. Now, all panels are visible without the need for any additional buttons like 'More Information' or 'Less Information.
Title and Icon in property Panel: In the collapsed and expanded mode now displays file titles with accompanying icons instead of the generic label "Details."
Dependent PR's:
ACA: Alfresco/alfresco-content-app#3477
ADW: https://github.com/Alfresco/alfresco-applications/pull/459
ui-property.webm