Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APPS-2108] ADF date-fns adapter implementation #8983

Merged
merged 6 commits into from
Oct 10, 2023
Merged

[APPS-2108] ADF date-fns adapter implementation #8983

merged 6 commits into from
Oct 10, 2023

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Oct 9, 2023 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • introduce ADF date-fns adapter
    • handle moment and date-fns formats
    • automatically switch locales based on user preferences
  • migrate Date Widget to date-fns
    • fix unit tests to always have correct Date value for fields (as per ISO and backend)
    • extra tests for min/max validation
    • tests now use proper form validators
  • remove protractor e2e for date widget that are already covered by unit tests
Screenshot 2023-10-09 at 19 58 15

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/APPS-2108

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit ce54924 into develop Oct 10, 2023
33 checks passed
@DenysVuika DenysVuika deleted the date-widget-datefns branch October 10, 2023 10:58
wiktord2000 pushed a commit that referenced this pull request Oct 11, 2023
@DenysVuika @wiktord2000
[APPS-2108] ADF date-fns adapter implementation (#8983)
9aaac94 
* adf date-fns adapter, migrate date widget

* [ci:force] fix tests

* [ci:force] update docs

* fix types and tests

* fix how the real date is stored, extra tests

* remove useless e2e as covered by tests already
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MichalKinas MichalKinas MichalKinas approved these changes

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DenysVuika @swapnil-verma-gl @MichalKinas @AleksanderSklorz