Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5742] Fix Search e2e's #8902

Merged
merged 6 commits into from
Sep 12, 2023
Merged

[ACS-5742] Fix Search e2e's #8902

merged 6 commits into from
Sep 12, 2023

Conversation

nikita-web-ua
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://alfresco.atlassian.net/browse/ACS-5742

What is the new behaviour?

Fixed failing search e2e's

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

swapnil-verma-gl
swapnil-verma-gl approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@swapnil-verma-gl swapnil-verma-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to trigger E2Es

@nikita-web-ua nikita-web-ua marked this pull request as ready for review September 11, 2023 16:50
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit 0d5e70e into develop Sep 12, 2023
33 checks passed
@DenysVuika DenysVuika deleted the dev-mmaliarchuk/ACS-5742-fix-search-e2e branch September 12, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swapnil-verma-gl swapnil-verma-gl swapnil-verma-gl approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@eromano eromano Awaiting requested review from eromano eromano is a code owner

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

Assignees
No one assigned
Labels
A/N BDU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-web-ua @DenysVuika @swapnil-verma-gl