Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACA-4313] - Sort order doesn't work correctly #8892

Merged
merged 2 commits into from
Sep 12, 2023
Merged

[ACA-4313] - Sort order doesn't work correctly #8892

merged 2 commits into from
Sep 12, 2023

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
When changing sorting in files and opening and closing preview for a file, the sorting is not applied correctly.

What is the new behaviour?
Proper sorting is applied every time it is set.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACA-4313-sort-order-doesnt-work-correctly branch from 30c08f6 to c8104a5 Compare September 8, 2023 10:39
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACA-4313-sort-order-doesnt-work-correctly branch from c8104a5 to 86d5266 Compare September 8, 2023 13:53
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika
Copy link
Contributor

@eromano is the PR fine now? can it be merged?

@dominikiwanekhyland dominikiwanekhyland merged commit e14e489 into develop Sep 12, 2023
@dominikiwanekhyland dominikiwanekhyland deleted the ACA-4313-sort-order-doesnt-work-correctly branch September 12, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichalKinas MichalKinas MichalKinas approved these changes

@eromano eromano eromano approved these changes

@DenysVuika DenysVuika DenysVuika approved these changes

@popovicsandras popovicsandras Awaiting requested review from popovicsandras popovicsandras is a code owner

@nikita-web-ua nikita-web-ua Awaiting requested review from nikita-web-ua

@swapnil-verma-gl swapnil-verma-gl Awaiting requested review from swapnil-verma-gl

@AleksanderSklorz AleksanderSklorz Awaiting requested review from AleksanderSklorz

Assignees
No one assigned
Labels
A/N BDU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dominikiwanekhyland @DenysVuika @eromano @MichalKinas