Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-15221 Allow multiple roles when fetching deployed applications #10503

Merged
merged 1 commit into from
Jan 8, 2025
Merged

AAE-15221 Allow multiple roles when fetching deployed applications #10503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/process-services-cloud/src/lib/app/services/apps-process-cloud.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ export class AppsProcessCloudService {
* Gets a list of deployed apps for this user by status.
*
* @param status Required status value
* @param role to filter the apps
* @param roles to filter the apps
* @returns The list of deployed apps
*/
getDeployedApplicationsByStatus(status: string, role?: string): Observable<ApplicationInstanceModel[]> {
return this.hasDeployedApps() ? of(this.deployedApps) : this.getApplicationsByStatus(status, role);
getDeployedApplicationsByStatus(status: string, roles?: string | string[]): Observable<ApplicationInstanceModel[]> {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading it right, roles can be either a string or a string array, or is this casting a string as a string array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roles can be either a string or a string array.

return this.hasDeployedApps() ? of(this.deployedApps) : this.getApplicationsByStatus(status, roles);
}

hasDeployedApps(): boolean {
Expand All @@ -66,13 +66,13 @@ export class AppsProcessCloudService {
}
}

private getApplicationsByStatus(status: string, role?: string): Observable<ApplicationInstanceModel[]> {
private getApplicationsByStatus(status: string, roles?: string | string[]): Observable<ApplicationInstanceModel[]> {
if (status === '') {
return of([]);
}
const path = this.getApplicationUrl();
const pathParams = {};
const queryParams = { status, roles: role, sort: 'name' };
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for arrays, does it need to be formatted somehow, i.e. comma-separated list?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. Angular's HttpParams class is designed to accept an array.

const queryParams = { status, roles, sort: 'name' };
const httpMethod = 'GET';
const headerParams = {};
const formParams = {};
Expand Down
Loading