[ACS-8918] search date filter changing between created and modified tabs slides the text inside the tabs too #10455
Conversation
AleksanderSklorz
requested review from
nikita-web-ua,
swapnil-verma-gl,
MichalKinas and
dominikiwanekhyland
AleksanderSklorz
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
AleksanderSklorz
changed the title
|
done |
| private readonly intersectionObserver = new IntersectionObserver( | ||
| (entries) => { | ||
| if (!entries[0].isIntersecting) { | ||
| this.tabGroup.selectedIndex = (this.selectedIndex + 1) % this.tabsContents.length; |
There was a problem hiding this comment.
Why do we need to set this.tabGroup.selectedIndex twice?
There was a problem hiding this comment.
This is some angular material problem when we use tabs together with some kind of overlaps like on below screenshot. Basically the problem is following:
When we close this popup then seems like Tabs component becomes broken because after reopening popup Tabs component doesn't know on which tab it was before closing so when we try to switch tab we can see for a moment strange text sliding effect.
To resolve that problem I wrote code which observes for hiding/showing component and I do single switching of tabs so Tabs component can restore it's state. It seems like only solution for that problem, because we can't just "destroy" tabs component and recreate it because we need to keep previous state.
AleksanderSklorz
deleted the
ACS-8918-Search-Date-Filter-Changing-between-Created-and-Modified-tabs-slides-the-text-inside-the-tabs-too
branch
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/ACS-8918
What is the new behaviour?
Text is not sliding when tabs are switched for date filter.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: