AAE-29002 Allow to filter processes by parentId #10453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alep85
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
DiogoABastos
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Just a small improvement suggestion: Group this "it should the payload contain..." tests under a describe("Payload") and refactor the tests, by running this spyOn(processListCloudService, 'getProcessByRequest').and.returnValue(of(fakeProcessCloudList)); in a beforeEach and renaming the tests to "it should contain..." (more readable)
alep85
force-pushed
the
improvement/AAE-29002-fe-create-filtered-main-process-id-column-in-process-instances-table
branch
from
f307173 to
1af0887
Compare
alep85
force-pushed
the
improvement/AAE-29002-fe-create-filtered-main-process-id-column-in-process-instances-table
branch
from
1af0887 to
f831ce4
Compare
|
alep85
deleted the
improvement/AAE-29002-fe-create-filtered-main-process-id-column-in-process-instances-table
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://hyland.atlassian.net/browse/AAE-29002
What is the new behaviour?
https://hyland.atlassian.net/browse/AAE-29002
Does this PR introduce a breaking change? (check one with "x")
No breaking changes running
link-adfhttps://github.com/Alfresco/hxp-frontend-apps/actions/runs/12141087493/job/33858547319If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: