Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAE-28454 Improve datatable actions display #10445

Merged

Conversation

DiogoABastos
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@alep85 alep85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but before merging, please raise a PR on HFA and use link-adf to be sure to not introduce BCs.

@DiogoABastos DiogoABastos force-pushed the improvement/AAE-28454-datatable-actions-column branch from db9f018 to 47fc432 Compare December 4, 2024 09:49
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
34.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@DiogoABastos DiogoABastos merged commit 70a38ae into develop Dec 4, 2024
17 of 18 checks passed
@DiogoABastos DiogoABastos deleted the improvement/AAE-28454-datatable-actions-column branch December 4, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants