Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-7905] ADF Core lib is missing dependency declaration #10444

Conversation

dominikiwanekhyland
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

https://hyland.atlassian.net/browse/ACS-7905

What is the new behaviour?
https://bundlephobia.com/package/@alfresco/[email protected]

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link
Contributor

@MichalKinas MichalKinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, please also get someone from HX to review

@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-7905-adf-core-lib-is-missing-dependency-declaration branch from c5e82e2 to 1066534 Compare December 4, 2024 06:56
@dominikiwanekhyland dominikiwanekhyland force-pushed the ACS-7905-adf-core-lib-is-missing-dependency-declaration branch from 1066534 to ed16dd8 Compare December 4, 2024 07:07
Copy link

sonarqubecloud bot commented Dec 4, 2024

@dominikiwanekhyland dominikiwanekhyland merged commit d93dbee into develop Dec 10, 2024
18 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the ACS-7905-adf-core-lib-is-missing-dependency-declaration branch December 10, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants