AAE-22900: update ObjectDataTableAdapter to support server and client… #10423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amolodyh-hyland
requested review from
dthornton-hyl,
jcain82,
sdonnell-hyland,
csandham and
DavidOlson-Hyland
amolodyh-hyland
requested review from
eromano,
popovicsandras and
DenysVuika
as code owners
amolodyh-hyland
commented
Nov 22, 2024
...cess-services-cloud/src/lib/process/process-list/datatable/process-list-datatable-adapter.ts
Show resolved
Hide resolved
amolodyh-hyland
commented
Nov 22, 2024
lib/process-services-cloud/src/lib/task/task-list/datatable/task-list-datatable-adapter.ts
Show resolved
Hide resolved
DenysVuika
reviewed
Nov 25, 2024
DenysVuika
reviewed
Nov 25, 2024
...services-cloud/src/lib/process/process-list/datatable/process-list-datatable-adapter.spec.ts
Outdated
Show resolved
Hide resolved
DenysVuika
reviewed
Nov 25, 2024
lib/process-services-cloud/src/lib/task/task-list/datatable/task-list-datatable-adapter.spec.ts
Outdated
Show resolved
Hide resolved
amolodyh-hyland
force-pushed
the
bug/AAE-22900-server-sorting
branch
from
a334e38 to
31c9a33
Compare
amolodyh-hyland
force-pushed
the
bug/AAE-22900-server-sorting
branch
from
24204c4 to
a2ccd6d
Compare
MichalKinas
approved these changes
Dec 6, 2024
jcain82
approved these changes
Dec 6, 2024
eromano
approved these changes
Dec 9, 2024
eromano
approved these changes
Dec 9, 2024
|
|
@amolodyh-hyland you van squash merge when you are ready and is green if the PR should not merged lease add draft or do not merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes AAE-22900. This adds server sorting for the base
ObjectDataTableAdapterto enable tables in tabs such as "Process Admin" User Tasks, Services Tasks, and Applications List.Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
AAE-22900
What is the new behaviour?
Allows for enabling server sorting where it the adapter does not sort the data. The server data is rendered in the order it comes in.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
This a partial fix to the provided story AAE-22900. After this is merged, hxp-frontend-apps will need to be updated by updating the
applications-list-filtered-data-adapteradapter as well.