[ACS-8918] Fixed failed job, fixed sonar, addressing PR comments

Alfresco · Dec 4, 2024 · a200926 · a200926
1 parent 18e968a
commit a200926
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/...ces/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.spec.ts b/...ces/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.spec.ts
@@ -37,15 +37,13 @@ import { NoopTranslateModule } from '@alfresco/adf-core';
 class SearchFilterTabbedTestComponent {}
 
 describe('SearchFilterTabbedComponent', () => {
-    let searchFilterTabbedTestComponent: SearchFilterTabbedTestComponent;
     let searchFilterTabbedTestFixture: ComponentFixture<SearchFilterTabbedTestComponent>;
 
     beforeEach(() => {
         TestBed.configureTestingModule({
             imports: [SearchFilterTabbedTestComponent, NoopTranslateModule, ContentTestingModule]
         });
         searchFilterTabbedTestFixture = TestBed.createComponent(SearchFilterTabbedTestComponent);
-        searchFilterTabbedTestComponent = searchFilterTabbedTestFixture.componentInstance;
     });
 
     describe('ngOnInit', () => {

diff --git a/...services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.ts b/...services/src/lib/search/components/search-filter-tabbed/search-filter-tabbed.component.ts
@@ -36,9 +36,9 @@ export class SearchFilterTabbedComponent implements OnInit, OnDestroy {
     selectedIndex: number = 0;
 
     @ViewChild(MatTabGroup)
-    private tabGroup: MatTabGroup;
+    private readonly tabGroup: MatTabGroup;
 
-    private intersectionObserver = new IntersectionObserver(
+    private readonly intersectionObserver = new IntersectionObserver(
         (entries) => {
             if (!entries[0].isIntersecting) {
                 this.tabGroup.selectedIndex = (this.selectedIndex + 1) % this.tabsContents.length;
@@ -52,7 +52,7 @@ export class SearchFilterTabbedComponent implements OnInit, OnDestroy {
         }
     );
 
-    constructor(private element: ElementRef, private changeDetector: ChangeDetectorRef) {}
+    constructor(private readonly element: ElementRef, private readonly changeDetector: ChangeDetectorRef) {}
 
     ngOnInit(): void {
         this.intersectionObserver.observe(this.element.nativeElement);