Skip to content

Commit

Permalink
Fix AAE-16968 BC (#9010)
Browse files Browse the repository at this point in the history
* Fix AAE-16968 BC

* Fix incorrect import

* Move DataColumnType to extensions lib

* Lint fixes
  • Loading branch information
MichalKinas authored Oct 19, 2023
1 parent 6644f53 commit 7c4304a
Show file tree
Hide file tree
Showing 5 changed files with 22 additions and 19 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
/* eslint-disable @angular-eslint/component-selector, @angular-eslint/no-input-rename */

import { Component, ContentChild, Input, OnInit, TemplateRef } from '@angular/core';
import { DataColumnType } from '../public-api';
import { DataColumnType } from '@alfresco/adf-extensions';

@Component({
selector: 'data-column',
Expand Down
16 changes: 1 addition & 15 deletions lib/core/src/lib/datatable/data/data-column.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,7 @@
*/

import { TemplateRef } from '@angular/core';

export interface DataColumnTypes {
text: string;
image: string;
date: string;
json: string;
icon: string;
fileSize: string;
location: string;
// eslint-disable-next-line id-blacklist
boolean: string;
amount: string;
}

export type DataColumnType = keyof DataColumnTypes;
import { DataColumnType } from '@alfresco/adf-extensions';

export interface DataColumn<T = unknown> {
id?: string;
Expand Down
3 changes: 2 additions & 1 deletion lib/core/src/lib/datatable/data/object-datacolumn.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,8 @@
*/

import { TemplateRef } from '@angular/core';
import { CurrencyConfig, DataColumn, DataColumnType } from './data-column.model';
import { DataColumnType } from '@alfresco/adf-extensions';
import { CurrencyConfig, DataColumn } from './data-column.model';

// Simple implementation of the DataColumn interface.
export class ObjectDataColumn<T = unknown> implements DataColumn<T> {
Expand Down
17 changes: 16 additions & 1 deletion lib/extensions/src/lib/config/document-list.extensions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,24 @@

import { ExtensionElement } from './extension-element';

export interface DataColumnTypes {
text: string;
image: string;
date: string;
json: string;
icon: string;
fileSize: string;
location: string;
// eslint-disable-next-line id-blacklist
boolean: string;
amount: string;
}

export type DataColumnType = keyof DataColumnTypes;

export interface DocumentListPresetRef extends ExtensionElement {
key: string;
type: string; // text|image|date
type: DataColumnType;
title?: string;
format?: string;
class?: string;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@
*/

import { Injectable } from '@angular/core';
import { DataColumn, DataColumnType } from '@alfresco/adf-core';
import { DataColumn } from '@alfresco/adf-core';
import { ProcessListDataColumnCustomData } from '../models/data-column-custom-data';
import { ProcessInstanceVariable, WithVariablesMap } from '../models/process-instance-variable.model';
import { DataColumnType } from '@alfresco/adf-extensions';

@Injectable({ providedIn: 'root' })
export class VariableMapperService {
Expand Down

0 comments on commit 7c4304a

Please sign in to comment.