[MNT-24657] cr fixes

Alfresco · Dec 4, 2024 · 6c74f99 · 6c74f99
1 parent 52f19aa
commit 6c74f99
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/lib/process-services/src/lib/form/widgets/people/people.widget.html b/lib/process-services/src/lib/form/widgets/people/people.widget.html
@@ -4,7 +4,7 @@
      id="people-widget-content">
     <mat-form-field>
         <label class="adf-label" [attr.for]="field.id">{{field.name | translate }}<span class="adf-asterisk" *ngIf="isRequired()">*</span></label>
-        <mat-chip-grid #chipGrid aria-label="People selection" data-automation-id="adf-people-widget-chip-list">
+        <mat-chip-grid #chipGrid [attr.aria-label]="'ADF_PROCESS_LIST.START_PROCESS.FORM.LABEL.SELECTED_PEOPLE' | translate">
             <mat-chip-row
                 *ngFor="let user of selectedUsers"
                 (removed)="onRemove(user)"

diff --git a/lib/process-services/src/lib/form/widgets/people/people.widget.spec.ts b/lib/process-services/src/lib/form/widgets/people/people.widget.spec.ts
@@ -35,6 +35,9 @@ describe('PeopleWidgetComponent', () => {
     let translationService: TranslateService;
     let peopleProcessService: PeopleProcessService;
 
+    const getChipById = async (id: string) =>
+        loader.getHarness(MatChipHarness.with({ selector: `[data-automation-id="adf-people-widget-chip-${id}"]` }));
+
     beforeEach(() => {
         TestBed.configureTestingModule({
             imports: [CoreTestingModule]
@@ -90,7 +93,7 @@ describe('PeopleWidgetComponent', () => {
         fixture.detectChanges();
         await fixture.whenStable();
 
-        const chip = await loader.getHarness(MatChipHarness.with({ selector: '[data-automation-id="adf-people-widget-chip-people-id"]' }));
+        const chip = await getChipById('people-id');
         expect(await chip.getText()).toBe('John Doe');
     });
 
@@ -134,7 +137,7 @@ describe('PeopleWidgetComponent', () => {
         fixture.detectChanges();
         await fixture.whenStable();
 
-        const chip = await loader.getHarness(MatChipHarness.with({ selector: '[data-automation-id="adf-people-widget-chip-people-id"]' }));
+        const chip = await getChipById('people-id');
         expect(await chip.getText()).toBe('John Doe');
         expect(await chip.isDisabled()).toBe(true);
         expect((element.querySelector('input') as HTMLInputElement).disabled).toBeTruthy();
@@ -153,7 +156,7 @@ describe('PeopleWidgetComponent', () => {
         fixture.detectChanges();
         await fixture.whenStable();
 
-        const chip = await loader.getHarness(MatChipHarness.with({ selector: '[data-automation-id="adf-people-widget-chip-people-id"]' }));
+        const chip = await getChipById('people-id');
         const cancelIcon = await chip.getRemoveButton();
         expect(cancelIcon).toBeDefined();
     });
@@ -194,7 +197,7 @@ describe('PeopleWidgetComponent', () => {
         fixture.detectChanges();
         await fixture.whenStable();
 
-        const chip = await loader.getHarness(MatChipHarness.with({ selector: '[data-automation-id="adf-people-widget-chip-people-id"]' }));
+        const chip = await getChipById('people-id');
         expect(await chip.getText()).toBe('John Doe');
     });
 

diff --git a/lib/process-services/src/lib/form/widgets/people/people.widget.ts b/lib/process-services/src/lib/form/widgets/people/people.widget.ts
@@ -168,7 +168,7 @@ export class PeopleWidgetComponent extends WidgetComponent implements OnInit {
     }
 
     isUserAlreadySelected(user: LightUserRepresentation): boolean {
-        if (this.selectedUsers && this.selectedUsers.length > 0) {
+        if (this.selectedUsers?.length > 0) {
             const result = this.selectedUsers.find((selectedUser) => selectedUser.id === user.id);
 
             return !!result;

diff --git a/lib/process-services/src/lib/i18n/en.json b/lib/process-services/src/lib/i18n/en.json
@@ -281,7 +281,8 @@
         "LABEL": {
           "SELECT_APPLICATION": "Select Application",
           "TYPE": "Select Process",
-          "NAME": "Process Name"
+          "NAME": "Process Name",
+          "SELECTED_PEOPLE": "Selected people"
         },
         "TYPE_PLACEHOLDER": "Choose one...",
         "ACTION": {