[AC-4556] Addressed code review findings

Alfresco · Dec 6, 2024 · 637ecac · 637ecac
1 parent e6876d7
commit 637ecac
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 36 deletions.
diff --git a/...t-node-selector/content-node-selector-panel/content-node-selector-panel.component.spec.ts b/...t-node-selector/content-node-selector-panel/content-node-selector-panel.component.spec.ts
@@ -441,7 +441,7 @@ describe('ContentNodeSelectorPanelComponent', () => {
                 const fakeNode = new Node({
                     id: 'fake-node',
                     path: { elements: [{ nodeType: 'st:site', name: 'fake-site' }] }
-                }) as Node;
+                });
                 component.chosenNode = [fakeNode];
                 component.documentList.currentFolderId = '-mysites-';
                 component.documentList.folderNode = fakeFolderNode;

diff --git a/...ontent-node-selector/content-node-selector-panel/content-node-selector-panel.component.ts b/...ontent-node-selector/content-node-selector-panel/content-node-selector-panel.component.ts
@@ -15,17 +15,7 @@
  * limitations under the License.
  */
 
-import {
-    Component,
-    DestroyRef,
-    EventEmitter,
-    inject,
-    Input,
-    OnInit,
-    Output,
-    ViewChild,
-    ViewEncapsulation
-} from '@angular/core';
+import { Component, DestroyRef, EventEmitter, inject, Input, OnInit, Output, ViewChild, ViewEncapsulation } from '@angular/core';
 import {
     CustomEmptyContentTemplateDirective,
     DataColumnComponent,
@@ -40,24 +30,9 @@ import {
     UserPreferencesService,
     UserPreferenceValues
 } from '@alfresco/adf-core';
-import {
-    FileUploadCompleteEvent,
-    FileUploadDeleteEvent,
-    NodesApiService,
-    SitesService,
-    UploadService
-} from '../../common';
+import { FileUploadCompleteEvent, FileUploadDeleteEvent, NodesApiService, SitesService, UploadService } from '../../common';
 import { ReactiveFormsModule, UntypedFormControl } from '@angular/forms';
-import {
-    Node,
-    NodeEntry,
-    NodePaging,
-    Pagination,
-    RequestScope,
-    SearchRequest,
-    SiteEntry,
-    SitePaging
-} from '@alfresco/js-api';
+import { Node, NodeEntry, NodePaging, Pagination, RequestScope, SearchRequest, SiteEntry, SitePaging } from '@alfresco/js-api';
 import { DocumentListComponent } from '../../document-list/components/document-list.component';
 import { RowFilter } from '../../document-list/data/row-filter.model';
 import { ImageResolver } from '../../document-list/data/image-resolver.model';
@@ -124,7 +99,7 @@ export class ContentNodeSelectorPanelComponent implements OnInit {
         skipCount: 0
     });
 
-    readonly DISABLE_ACTION_FOLDER_LIST = ['-mysites-'];
+    readonly disableActionFolderList = ['-mysites-'];
 
     private showSiteList = true;
     private showSearchField = true;
@@ -360,11 +335,13 @@ export class ContentNodeSelectorPanelComponent implements OnInit {
     }
 
     ngOnInit() {
-        this.searchInput.valueChanges.pipe(debounceTime(this.debounceSearch), takeUntilDestroyed(this.destroyRef)).subscribe((searchValue: string) => {
-            this.searchTerm = searchValue;
-            this.queryBuilderService.userQuery = searchValue.length > 0 ? `${searchValue}*` : searchValue;
-            this.queryBuilderService.update();
-        });
+        this.searchInput.valueChanges
+            .pipe(debounceTime(this.debounceSearch), takeUntilDestroyed(this.destroyRef))
+            .subscribe((searchValue: string) => {
+                this.searchTerm = searchValue;
+                this.queryBuilderService.userQuery = searchValue.length > 0 ? `${searchValue}*` : searchValue;
+                this.queryBuilderService.update();
+            });
 
         this.queryBuilderService.updated.pipe(takeUntilDestroyed(this.destroyRef)).subscribe((searchRequest) => {
             if (searchRequest) {
@@ -663,7 +640,7 @@ export class ContentNodeSelectorPanelComponent implements OnInit {
     }
 
     private isActionDisabledForFolder(folderId: string): boolean {
-        return this.DISABLE_ACTION_FOLDER_LIST.includes(folderId);
+        return this.disableActionFolderList.includes(folderId);
     }
 
     /**