[APPS-3060] Update JDK version to 21 #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
purusothaman-mm
requested review from
SathishK-T,
suneet-gupta,
code4uuuu and
mohit-singh4
suneet-gupta
reviewed
Oct 8, 2024
| @@ -1,4 +1,4 @@ | |||
| FROM amazoncorretto:17-alpine3.18@sha256:6a3dc573328ced158ae25ffde792accbe8b1ff2e7b505c72d2d5e7b9bfa9ac26 | |||
| FROM amazoncorretto:21-alpine3.18@sha256:6a3dc573328ced158ae25ffde792accbe8b1ff2e7b505c72d2d5e7b9bfa9ac26 | |||
There was a problem hiding this comment.
Please verify the image SHA
There was a problem hiding this comment.
Confirmed with devops to use the same SHA image
suneet-gupta
reviewed
Oct 8, 2024
| @@ -113,7 +113,7 @@ | |||
| <project.scm.repository>alfresco-java-sdk</project.scm.repository> | |||
| <project.year>2021</project.year> | |||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | |||
| <java.version>17</java.version> | |||
| <java.version>21</java.version> | |||
There was a problem hiding this comment.
Please check whether we can update java compile time as well to 21
There was a problem hiding this comment.
As discused confirming the changes with java 21 compile time as well
SathishK-T
reviewed
Oct 8, 2024
| @@ -14,13 +14,13 @@ to define a sample [```EventHandler```](../../alfresco-java-event-api/alfresco-j | |||
|
|
|||
| To properly build and run the project in a local environment it is required to have installed some tools. | |||
|
|
|||
| * Java 17: | |||
There was a problem hiding this comment.
Need to update the java version in the other read file as well.
There was a problem hiding this comment.
Updated the java version to 21 in readme file
suneet-gupta
approved these changes
Oct 8, 2024
suneet-gupta
added a commit
that referenced
this pull request
Oct 23, 2024
This reverts commit d0d4798.
suneet-gupta
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hyland.atlassian.net/browse/APPS-3060