Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2885 Fix secret template bug in search enterprise correcting search username reference #400

Merged
merged 1 commit into from
Oct 28, 2024
Merged

OPSEXP-2885 Fix secret template bug in search enterprise correcting search username reference #400

merged 1 commit into from
Oct 28, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented Oct 28, 2024

@pmacius pmacius requested review from gionn and alxgomz October 28, 2024 08:31
gionn
gionn requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

write a unit for the secret which should have exposed this issue before

@pmacius pmacius requested a review from gionn October 28, 2024 13:33
@pmacius
Copy link
Contributor Author

pmacius commented Oct 28, 2024

write a unit for the secret which should have exposed this issue before

Test for creating this secret are already there but this scenario Im not sure can be somehow covered.

@pmacius pmacius merged commit c5c74f6 into main Oct 28, 2024
9 checks passed
@pmacius pmacius deleted the OPSEXP-2885 branch October 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmacius @gionn