Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2435 Fix nodeSelector configuration in alfresco-repository #169

Merged
merged 1 commit into from
Dec 19, 2023
Merged

OPSEXP-2435 Fix nodeSelector configuration in alfresco-repository #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/alfresco-repository/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: alfresco-repository
description: Alfresco content repository Helm chart
type: application
version: 0.1.1
version: 0.1.2
appVersion: 23.1.1
dependencies:
- name: alfresco-common
Expand Down
2 changes: 1 addition & 1 deletion charts/alfresco-repository/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# alfresco-repository

![Version: 0.1.1](https://img.shields.io/badge/Version-0.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 23.1.1](https://img.shields.io/badge/AppVersion-23.1.1-informational?style=flat-square)
![Version: 0.1.2](https://img.shields.io/badge/Version-0.1.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 23.1.1](https://img.shields.io/badge/AppVersion-23.1.1-informational?style=flat-square)

Alfresco content repository Helm chart

Expand Down
4 changes: 1 addition & 3 deletions charts/alfresco-repository/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,6 @@ spec:
spec:
serviceAccountName: {{ include "alfresco-repository.serviceAccountName" . }}
{{- include "alfresco-common.component-pod-security-context" .Values | indent 4 }}
nodeSelector:
{{- toYaml .Values.nodeSelector | nindent 8 }}
{{- include "alfresco-common.imagePullSecrets" . | indent 6 }}
initContainers:
- name: wait-db-ready
Expand Down Expand Up @@ -221,7 +219,7 @@ spec:
terminationGracePeriodSeconds: {{ .Values.terminationGracePeriod }}
{{- with .Values.nodeSelector }}
nodeSelector:
{{- toYaml . | indent 8 }}
{{- toYaml . | nindent 8 }}
{{- end }}
{{- with .Values.affinity }}
affinity:
Expand Down
11 changes: 11 additions & 0 deletions charts/alfresco-repository/tests/deployment_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,3 +206,14 @@ tests:
path: spec.template.spec.containers
count: 2
template: deployment.yaml

- it: should allow setting nodeSelector properly
values: *test_values
set:
nodeSelector:
node_label: node_value
asserts:
- equal:
path: spec.template.spec.nodeSelector.node_label
value: node_value
template: deployment.yaml