Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2293: align alfresco-ai-transformer chart with latest practices #167

Merged
merged 39 commits into from
Dec 19, 2023
Merged
Changes from 1 commit
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
9948f80
add ai xform serviceaccount templates
alxgomz Dec 13, 2023
3fdc87c
simplify tests
alxgomz Dec 13, 2023
d6529f6
add service account in deployment with tests
alxgomz Dec 13, 2023
032442f
move AWS credentials in a secret and add existingSecret in values
alxgomz Dec 14, 2023
3f7105c
add tests
alxgomz Dec 14, 2023
e3d2cad
fix values key and default
alxgomz Dec 14, 2023
b3702ae
project secrets items in deployment
alxgomz Dec 14, 2023
b709743
add component recommended label
alxgomz Dec 14, 2023
ad8c9fc
simplify configmap and add tests
alxgomz Dec 14, 2023
6500fc1
add aws existingConfigMap
alxgomz Dec 14, 2023
75918d2
split aws config to its own configmap
alxgomz Dec 14, 2023
24d8a58
add aws configs to deployment
alxgomz Dec 14, 2023
d16c790
encode secrets values
alxgomz Dec 14, 2023
d515ddd
align AMQ existing secret usage
alxgomz Dec 14, 2023
b02eea2
remove unused value
alxgomz Dec 14, 2023
4111a6c
bump alfresco-comon dependency & move MQ URL from secret to cm
alxgomz Dec 14, 2023
6175c23
remove older alfresco.shortname template
alxgomz Dec 14, 2023
90f2816
add broker credentials in deployment and tests
alxgomz Dec 14, 2023
2fc0fb7
simplify cm tests
alxgomz Dec 15, 2023
cd0ea58
add broker url in deployment
alxgomz Dec 15, 2023
3394c4a
fail on empty mq url
alxgomz Dec 15, 2023
08190f7
move to tag based dependencies management
alxgomz Dec 15, 2023
2543bf1
bump activemq dep
alxgomz Dec 15, 2023
ae539a7
remove old flag references
alxgomz Dec 15, 2023
ee9f896
add filestore values
alxgomz Dec 18, 2023
33c603c
use values in configmap
alxgomz Dec 18, 2023
f908f69
add configmap tests
alxgomz Dec 18, 2023
d39c49c
add sfs url env var in deployment
alxgomz Dec 18, 2023
56f7ec4
add tests
alxgomz Dec 18, 2023
99c5cf2
bump ai-transformer chart
alxgomz Dec 18, 2023
1ff1cc5
add missing service account template
alxgomz Dec 18, 2023
046f264
remove reference to older secret
alxgomz Dec 18, 2023
0c74994
split sfs cm to a dedicated one
alxgomz Dec 18, 2023
12a944d
rename aws secret and cm
alxgomz Dec 18, 2023
eb2a6ca
fixed name activemq in CI
alxgomz Dec 18, 2023
cf0986e
fixup
alxgomz Dec 18, 2023
2249b43
remove cluncky checksum support
alxgomz Dec 18, 2023
bddf0e6
remove non full qualified template names
alxgomz Dec 18, 2023
7b9397f
fix linter
alxgomz Dec 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add tests
alxgomz committed Dec 19, 2023
commit 56f7ec4dad355726d04cc3d81ae615e9e3c2c49a
Original file line number Diff line number Diff line change
@@ -72,7 +72,7 @@ spec:
{{- $awsSecretCtx := dict "Values" (dict "nameOverride" "aws") "Chart" $.Chart "Release" $.Release }}
{{- $awsSecret := coalesce .Values.aws.existingSecret.name (include "alfresco-ai-transformer.fullname" $awsSecretCtx) }}
{{- $awsCmCtx := dict "Values" (dict "nameOverride" "aws") "Chart" $.Chart "Release" $.Release }}
{{- $awsCm := coalesce .Values.aws.existingSecret.name (include "alfresco-ai-transformer.fullname" $awsCmCtx) }}
{{- $awsCm := coalesce .Values.aws.existingConfigMap.name (include "alfresco-ai-transformer.fullname" $awsCmCtx) }}
{{- $mqCmCtx := dict "Values" (dict "nameOverride" "ai-mq") "Chart" $.Chart "Release" $.Release }}
{{- $mqCm := coalesce .Values.messageBroker.existingSecret.name (include "alfresco-ai-transformer.fullname" $mqCmCtx) }}
{{- $sfsCm := coalesce .Values.sfs.existingConfigMap.name (include "alfresco-ai-transformer.fullname" .) }}
Original file line number Diff line number Diff line change
@@ -78,14 +78,79 @@ tests:
limits:
cpu: "2"
memory: "1000Mi"
- it: should have basic metadata in place
- it: should render deployment with existing secrets and configmaps
values: *testvalues
set:
serviceAccount:
create: false
name: null
sfs:
existingConfigMap:
name: sfsurl
keys:
url: SFS_URL
aws:
existingSecret:
name: awscreds
keys:
accessKeyId: AWSACCESSKEYID
secretAccessKey: AWSSECRETACCESSKEY
existingConfigMap:
name: amazon
keys:
region: REGION
s3Bucket: comprehendbucket
comprehendRoleARN: ROLE
template: deployment-ai-transformer.yaml
asserts:
- equal:
path: spec.template.spec.serviceAccountName
value: default
- contains:
path: spec.template.spec.containers[0].env
content:
name: AWS_ACCESS_KEY_ID
valuesFrom:
secretKeyRef:
name: awscreds
key: AWSACCESSKEYID
- contains:
path: spec.template.spec.containers[0].env
content:
name: AWS_SECRET_ACCESS_KEY
valuesFrom:
secretKeyRef:
name: awscreds
key: AWSSECRETACCESSKEY
- contains:
path: spec.template.spec.containers[0].env
content:
name: FILE_STORE_URL
valuesFrom:
configMapKeyRef:
name: sfsurl
key: SFS_URL
- contains:
path: spec.template.spec.containers[0].env
content:
name: AWS_REGION
valuesFrom:
configMapKeyRef:
name: amazon
key: REGION
- contains:
path: spec.template.spec.containers[0].env
content:
name: AWS_S3_BUCKET
valuesFrom:
configMapKeyRef:
name: amazon
key: comprehendbucket
- contains:
path: spec.template.spec.containers[0].env
content:
name: AWS_COMPREHEND_ROLE_ARN
valuesFrom:
configMapKeyRef:
name: amazon
key: ROLE