Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-2364 Ensure release charts doesn't have pre-release dependencies #151

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 8, 2023

@gionn gionn requested review from alxgomz and slohe1 November 8, 2023 11:54
@gionn gionn self-assigned this Nov 8, 2023
@gionn gionn force-pushed the OPSEXP-2364-no-prerelease-script branch from 9a65503 to 28cc470 Compare November 8, 2023 11:54
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have checked that at release time only (so probably not with pre-commit) but otherwise LGTM.
Do you want to add more stuff (still in draft)?

@gionn gionn marked this pull request as ready for review November 8, 2023 13:45
@gionn
Copy link
Member Author

gionn commented Nov 8, 2023

I would have checked that at release time only (so probably not with pre-commit) but otherwise LGTM. Do you want to add more stuff (still in draft)?

this time really forgot because I was in a hurry :D

I put it in pre-commit because the check is fine to be always enforced: if you want to use an alpha dependency then you never want to release it with a non-alpha chart. (and of course it's very fast to check)

@gionn gionn requested a review from alxgomz November 8, 2023 13:47
@gionn gionn merged commit 6b45137 into main Nov 8, 2023
2 checks passed
@gionn gionn deleted the OPSEXP-2364-no-prerelease-script branch November 8, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants