Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2292 Review and align chart activemq with newer principals #144

Merged
merged 3 commits into from
Nov 7, 2023
Merged

OPSEXP-2292 Review and align chart activemq with newer principals #144

merged 3 commits into from
Nov 7, 2023

Conversation

slohe1
Copy link
Contributor

@slohe1 slohe1 commented Nov 6, 2023

@slohe1 slohe1 marked this pull request as draft November 6, 2023 11:45
@slohe1 slohe1 marked this pull request as ready for review November 6, 2023 21:12
@slohe1 slohe1 requested review from gionn and alxgomz November 6, 2023 21:12
gionn
gionn approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adminUser.* is not totally like in other chart but I will avoid to break again the compatibility here given that the feature is still usable (except the customization of key names in the secret)

@slohe1 slohe1 merged commit f2f084c into main Nov 7, 2023
2 checks passed
@slohe1 slohe1 deleted the OPSEXP-2292 branch November 7, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

@alxgomz alxgomz Awaiting requested review from alxgomz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slohe1 @gionn