OPSEXP-2298: allow elasticsearch configuration using the same existingResource or values approach #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
reviewed
Oct 23, 2023
Comment on lines
85
to
88
| | searchIndex.existingConfigMap.keys.url | string | `"ELASTICSEARCH_URL"` | Key within the configmap holding the URL of the elasticsearch service | | ||
| | searchIndex.existingConfigMap.name | string | `nil` | Alternatively, provide message broker connection details via an existing configmap | | ||
| | searchIndex.existingSecret.keys.password | string | `"ELASTICSEARCH_PASSWORD"` | Key within the secret that holds the elasticsearch password | | ||
| | searchIndex.existingSecret.keys.username | string | `"ELASTICSEARCH_USERNAME"` | Key within the secret that holds the elasticsearch username | |
There was a problem hiding this comment.
at this point better have generic keys in the cm/secret to avoid referring to the specific product?
There was a problem hiding this comment.
I also renamed searchIndex to search to match naming in other charts (repo & acs)
gionn
approved these changes
Oct 23, 2023
| # -- Valid values are http or https | ||
| protocol: null | ||
| # -- The username required to access the service, if any | ||
| search: |
There was a problem hiding this comment.
maybe a little too generic but ok
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref OPSEXP-2298