OPSEXP-2286: allow passing the ATS location #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gionn
approved these changes
Sep 22, 2023
Comment on lines
104
to
108
| elasticsearch: | ||
| # -- Enable embedded elasticsearch - useful when using this chart in standalone | ||
| enabled: false | ||
| replicas: 1 | ||
| clusterHealthCheckParams: "wait_for_status=yellow&timeout=1s" |
There was a problem hiding this comment.
do you want to move also this to the bottom if the intention is to have all values related to testing at the bottom?
| {{- end -}} | ||
|
|
||
| {{- define "alfresco-search-enterprise.config.spring" -}} | ||
| {{- if .Values.elasticsearch.enabled }} | ||
| {{- if .Values.elasticsearch.enabled -}} |
There was a problem hiding this comment.
is the closing - really necessary?
There was a problem hiding this comment.
that's cosmetic tbh 💅 ut I would argue that a named template should never start with a carriage return.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: OPSEXP-2286
Previous the ATS location was only computed using an old chart and only worked if the ats router and sfs were using specific name prefixes (alfresco-cs & alfresco)
That PR allow passing the ATS details in values or configmap, making either of both mandatory.