Skip to content

Commit

Permalink
OPSEXP-2504 Avoid setting rollingUpdate when unnecessary in filestore (
Browse files Browse the repository at this point in the history
  • Loading branch information
gionn authored Aug 20, 2024
1 parent a4b5dcf commit e31c59f
Show file tree
Hide file tree
Showing 4 changed files with 13 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/alfresco-transform-service/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: alfresco-transform-service
description: A Helm chart for deploying Alfresco Transform Services
type: application
version: 2.1.0-alpha.0
version: 2.1.0-alpha.1
appVersion: 4.1.3
dependencies:
- name: alfresco-common
Expand Down
2 changes: 1 addition & 1 deletion charts/alfresco-transform-service/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ parent: Charts Reference

# alfresco-transform-service

![Version: 2.1.0-alpha.0](https://img.shields.io/badge/Version-2.1.0--alpha.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.1.3](https://img.shields.io/badge/AppVersion-4.1.3-informational?style=flat-square)
![Version: 2.1.0-alpha.1](https://img.shields.io/badge/Version-2.1.0--alpha.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 4.1.3](https://img.shields.io/badge/AppVersion-4.1.3-informational?style=flat-square)

A Helm chart for deploying Alfresco Transform Services

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,10 @@ spec:
{{- include "alfresco-transform-service.filestore.selectorLabels" . | nindent 6 }}
strategy:
type: {{ .Values.filestore.strategy.type }}
{{- if eq .Values.filestore.strategy.type "RollingUpdate" }}
rollingUpdate:
{{- toYaml .Values.global.strategy.rollingUpdate | nindent 6 }}
{{- end }}
template:
metadata:
annotations:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ tests:
path: spec.strategy.type
value: RollingUpdate
template: deployment-filestore.yaml
- equal:
path: spec.strategy.rollingUpdate
value:
maxSurge: 1
maxUnavailable: 0
template: deployment-filestore.yaml
- it: should render overridden strategy type
set:
filestore:
Expand All @@ -21,3 +27,6 @@ tests:
path: spec.strategy.type
value: Recreate
template: deployment-filestore.yaml
- notExists:
path: spec.strategy.rollingUpdate
template: deployment-filestore.yaml

0 comments on commit e31c59f

Please sign in to comment.