Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2240 Provide a rockylinux 9 + tomcat 10 tomcat base image #109

Merged
merged 15 commits into from
Sep 22, 2023
Merged

OPSEXP-2240 Provide a rockylinux 9 + tomcat 10 tomcat base image #109

merged 15 commits into from
Sep 22, 2023

Conversation

slohe1
Copy link
Contributor

@slohe1 slohe1 commented Sep 20, 2023

@slohe1 slohe1 marked this pull request as draft September 20, 2023 16:13
@slohe1 slohe1 marked this pull request as ready for review September 21, 2023 07:31
@slohe1 slohe1 requested review from alxgomz and gionn September 21, 2023 07:31
gionn
gionn reviewed Sep 21, 2023
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are a bunch of dependabots open on this repo, merge them and verify as part of this jira

.github/workflows/main.yml Outdated Show resolved Hide resolved
alxgomz
alxgomz requested changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not produce this one as tomcat 10 is only supported starting with 23.1 and centos 7 is not anymore on the supported stack for 23.1.
the only centos7 based image we need is tomcat9 + jre 11

gionn
gionn reviewed Sep 21, 2023
View reviewed changes
.github/workflows/main.yml Outdated Show resolved Hide resolved
@slohe1 slohe1 requested review from gionn and alxgomz September 21, 2023 19:59
@slohe1 slohe1 merged commit 1d52432 into master Sep 22, 2023
6 checks passed
@slohe1 slohe1 deleted the OPSEXP-2240-tomcat branch September 22, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slohe1 @gionn @alxgomz