Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-9012] Truncate text in saved searches description #4265

Merged

Conversation

MichalKinas
Copy link
Contributor

Add text truncation in saved searches description column, added missing docs in extension.schema.json and fixed one small bug in unique saved search name validator.
https://hyland.atlassian.net/browse/ACS-9012

@AleksanderSklorz
Copy link
Contributor

@MichalKinas I see that actually only description column is truncated but if you check task's title it says about "name" column. Should we truncate name column as well?
image

@AleksanderSklorz
Copy link
Contributor

Should we truncate entry in sidebar as well? Actually it doesn't look good because text goes outside of available space:
image

@MichalKinas
Copy link
Contributor Author

@MichalKinas I see that actually only description column is truncated but if you check task's title it says about "name" column. Should we truncate name column as well? image

Yes, I think this was misunderstood since I think the original idea was to truncate description column but I think for name it also makes a lot of sense

@MichalKinas
Copy link
Contributor Author

Should we truncate entry in sidebar as well? Actually it doesn't look good because text goes outside of available space: image

Good point, fixed

@MichalKinas MichalKinas force-pushed the ACS-9012-limit-saved-searches-description-length branch from 750f4f4 to 9d97dfd Compare December 5, 2024 09:49
@MichalKinas MichalKinas force-pushed the ACS-9012-limit-saved-searches-description-length branch from d501b8d to 4b27403 Compare December 5, 2024 13:45
Copy link

sonarqubecloud bot commented Dec 5, 2024

@MichalKinas MichalKinas merged commit 93157d2 into develop Dec 5, 2024
26 checks passed
@MichalKinas MichalKinas deleted the ACS-9012-limit-saved-searches-description-length branch December 5, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants