New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-8694] Cleanup of visibility rules for extensions in ACA #4140

Open

swapnil-verma-gl wants to merge 25 commits into develop from dev-acs-8694-cleanup-visible-rules

Contributor

swapnil-verma-gl commented Sep 25, 2024 •

edited

Loading

JIRA ticket link or changeset's description

https://hyland.atlassian.net/browse/ACS-8694

Updated ACA extensions config to use array based visibility rules instead of string based. Also removed various unused rules

This is a breaking change

swapnil-verma-gl requested review from DenysVuika and MichalKinas

September 25, 2024 07:27

swapnil-verma-gl added breaking change do not merge labels

swapnil-verma-gl marked this pull request as ready for review

September 26, 2024 07:49

Contributor Author

swapnil-verma-gl commented Sep 26, 2024

This PR should not be merged to develop, before the merge of #4139 to this branch

AleksanderSklorz reviewed

View reviewed changes

docs/extending/rules.md Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

AleksanderSklorz reviewed

View reviewed changes

projects/aca-shared/rules/src/app.rules.spec.ts Outdated Show resolved Hide resolved

Contributor

AleksanderSklorz commented Oct 10, 2024

Great work @swapnil-verma-gl with cleaning up of these rules :D

Contributor Author

swapnil-verma-gl commented Oct 11, 2024

This PR should not be merged to develop, before the merge of #4139 to this branch

#4139 merged to this branch. This PR can now be merged to develop after sufficient code review approvals. Removing 'Do not merge' label

swapnil-verma-gl removed the do not merge label

AleksanderSklorz approved these changes

View reviewed changes

swapnil-verma-gl added 14 commits

November 4, 2024 13:54


          [ACS-8694] Updated occurrences of visible in extensions.json to use a…

4c044df

…rrays instead of single strings. Cleaned up rules in aca-content.module.ts


          [ACS-8694] Removed extra commas

ad84694


          [ACS-8694] Broke down canDelete rule into seperate entities

c83af45


          [ACS-8694] Fixed typo for notEmpty rule

7324aa3


          [ACS-8694] Fixed rule for edit offline

db27f56


          [ACS-8694] Updated extension.schema.json

5c5eda8


          [ACS-8694] Updated extension.schema.json

b4cc744


          [ACS-8694] Fixed rule for manage versions context menu item

68416ae


          [ACS-8694] Fixed rule for manage versions and manage permissions


          [ACS-8694] Added rules.canManageFolderRules

9568dd7


          [ACS-8694] Fixed typo

1a25921


          [ACS-8694] Updated visibility rules for folder rules and AOS plugin

f16aa54


          [ACS-8694] Updated extension.schema.json

ab00283


          [ACS-8694] Updated existing rules to use !isTrashcan() instead of isN…

66c5f0e

…otTrashcan()

swapnil-verma-gl and others added 10 commits

November 4, 2024 13:54


          [ACS-8694] folder-rules.plugin.json now uses arrays for controlling v…

bafbd16

…isibility


          [ACS-8694] Updated app.extensions.schema

dc8b2b5


          [ACS-8694] Removed unused rules

fb140b4


          [ACS-8694] Added unit tests for canToggleFileLock

f430cf4


          [ACS-8694] Added rules-list.md

8a9f3cb


          [ACS-8694] Revert unneeded project.json change

82b1929


          [ACS-8694] Fixed toggleEditOffline rule

75465ba


          [ACS-8694] Added migration guide (#4139)

ad392c7

* [ACS-8694] Added migration guide

* [ACS-8694] Fixed typo

* [ACS-8694] Added missing rule migration. Fixed incorrect rule migration. Fixed typos


          [ACS-8694] Code review finding - Replaced instance of any

104e438


          [ACS-8694] Code review finding - Updated rules.md. Removed duplicatio…

dab8da7

…n of rules list from rules-list.md. Added pointer to rules-list.md under tips section

swapnil-verma-gl force-pushed the dev-acs-8694-cleanup-visible-rules branch from deb240e to dab8da7 Compare

November 4, 2024 08:27


          [ACS-8694] Fixed build issue

4ea6dfb

sonarqubecloud bot commented Nov 6, 2024

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

dominikiwanekhyland approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change