Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6699] cleanup user info menu and details #3625

Merged
merged 2 commits into from
Feb 2, 2024
Merged

Conversation

DenysVuika
Copy link
Contributor

@DenysVuika DenysVuika commented Jan 31, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

What is the new behaviour?

  • remove code and test duplication, use already existing services and data to get user profile information
  • remove useless http calls and code from user menu
  • remove useless http calls and code from user details menu item

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6699

@DenysVuika DenysVuika changed the title cleanup user info menu and details [ACS-6699] cleanup user info menu and details Feb 1, 2024
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DenysVuika DenysVuika merged commit 4393f33 into develop Feb 2, 2024
25 of 27 checks passed
@DenysVuika DenysVuika deleted the cleanup-user-info branch February 2, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants