-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6666] e2e migration for info drawer file folder properties tests #3623
Merged
datguychen
merged 11 commits into
develop
from
ACS-6666-e2e-migration-for-infoDrawer-file-folder-properties-tests
Feb 6, 2024
Merged
[ACS-6666] e2e migration for info drawer file folder properties tests #3623
datguychen
merged 11 commits into
develop
from
ACS-6666-e2e-migration-for-infoDrawer-file-folder-properties-tests
Feb 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datguychen
requested review from
DenysVuika,
akashrathod28,
MichalKinas,
AleksanderSklorz and
katarzynakita
January 31, 2024 10:10
e2e/playwright/info-drawer/src/tests/file-folder-properties.spec.ts
Outdated
Show resolved
Hide resolved
@@ -36,4 +36,48 @@ export class AdfInfoDrawerComponent extends BaseComponent { | |||
public getIdField = (labelText: string) => this.getChild('[data-automation-id="library-id-properties-wrapper"]', { hasText: labelText }); | |||
public getVisibilityField = (labelText: string) => this.getChild('[data-automation-id="library-visibility-properties-wrapper"]', { hasText: labelText }); | |||
public getDescriptionField = this.getChild('[data-automation-id="library-description-properties-wrapper"] textarea'); | |||
public propertiesTab = this.getChild('.adf-info-drawer-tab').nth(0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have twice this.getChild('.adf-info-drawer-tab') - could you please move it to some field to avoid looking for the same element twice?
datguychen
force-pushed
the
ACS-6666-e2e-migration-for-infoDrawer-file-folder-properties-tests
branch
from
February 5, 2024 15:34
6231172
to
02fcba4
Compare
akashrathod28
approved these changes
Feb 6, 2024
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
AleksanderSklorz
approved these changes
Feb 6, 2024
datguychen
deleted the
ACS-6666-e2e-migration-for-infoDrawer-file-folder-properties-tests
branch
February 6, 2024 10:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6666
What is the new behaviour?
Migrated e2e infoDrawer - file folder properties tests from Protractor to Playwright
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: