[ACS-6140] - Remove references to internal Angular Material CSS classes #3620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
MichalKinas,
DenysVuika,
nikita-web-ua,
swapnil-verma-gl and
AleksanderSklorz
DenysVuika
reviewed
Feb 1, 2024
projects/aca-content/folder-rules/src/rule-details/rule-details.ui-component.ts
Outdated
Show resolved
Hide resolved
dominikiwanekhyland
force-pushed
the
ACS-6140-adf-remove-references-to-internal-angular-material-css-classes
branch
from
64af0e4 to
315cb33
Compare
| @@ -1,3 +1,4 @@ | |||
| /* stylelint-disable selector-class-pattern */ | |||
There was a problem hiding this comment.
Do you guys think it's allowable to disable that styleline rule for theme files? I think it's really difficult to modify those files as they mainly focus on adapting mat classes
There was a problem hiding this comment.
I think it's okay for me
dominikiwanekhyland
force-pushed
the
ACS-6140-adf-remove-references-to-internal-angular-material-css-classes
branch
7 times, most recently
from
3cfd407 to
bbd5997
Compare
dominikiwanekhyland
force-pushed
the
ACS-6140-adf-remove-references-to-internal-angular-material-css-classes
branch
from
bbd5997 to
35a3600
Compare
dominikiwanekhyland
force-pushed
the
ACS-6140-adf-remove-references-to-internal-angular-material-css-classes
branch
from
35a3600 to
33322b3
Compare
|
MichalKinas
approved these changes
Feb 13, 2024
|
Yes, I have, 2 times:
And I didn't find anything suspicious :) |
dominikiwanekhyland
deleted the
ACS-6140-adf-remove-references-to-internal-angular-material-css-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-6140
What is the new behaviour?
All internal Angular Material CSS classes are removed and replaced with our custom classes. Changes in Angular Material library with classes won't affect our app.
Also it contains adf-upstream
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: