Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ACS-5882] infoDrawer comments tests migrated to Playwright #3615

Merged
merged 8 commits into from
Feb 2, 2024
Merged

[ACS-5882] infoDrawer comments tests migrated to Playwright #3615

merged 8 commits into from
Feb 2, 2024

Conversation

datguychen
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/ACS-5882

What is the new behaviour?
Migrated e2e infoDrawer - comments tests from Protractor to Playwright

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@datguychen datguychen force-pushed the ACS-5882-e2e-migration-for-infoDrawer-comments-tests branch from 4d66538 to 21fb96d Compare January 26, 2024 10:26
@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

MichalKinas
MichalKinas reviewed Jan 26, 2024
View reviewed changes
e2e/playwright/info-drawer/playwright.config.ts Outdated Show resolved Hide resolved
e2e/playwright/info-drawer/playwright.config.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/components/adf-info-drawer.component.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/pages/favorites.page.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/pages/favorites.page.ts Outdated Show resolved Hide resolved
projects/aca-playwright-shared/src/page-objects/pages/recent-files.page.ts Outdated Show resolved Hide resolved
@datguychen datguychen marked this pull request as ready for review January 26, 2024 12:40
@datguychen datguychen force-pushed the ACS-5882-e2e-migration-for-infoDrawer-comments-tests branch 2 times, most recently from 39cf30c to d4f1adb Compare February 2, 2024 14:03
@datguychen datguychen force-pushed the ACS-5882-e2e-migration-for-infoDrawer-comments-tests branch from ca7c09c to 61e55ed Compare February 2, 2024 15:19
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 2, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@datguychen datguychen merged commit 489a847 into develop Feb 2, 2024
27 checks passed
@datguychen datguychen deleted the ACS-5882-e2e-migration-for-infoDrawer-comments-tests branch February 2, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderSklorz AleksanderSklorz AleksanderSklorz approved these changes

@MichalKinas MichalKinas MichalKinas approved these changes

@akashrathod28 akashrathod28 Awaiting requested review from akashrathod28

@DenysVuika DenysVuika Awaiting requested review from DenysVuika

@katarzynakita katarzynakita Awaiting requested review from katarzynakita

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@datguychen @CLAassistant @DenysVuika @MichalKinas @AleksanderSklorz @katarzynakita