Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6642] Tags column and getTags API call is now dynamic on app.config.json for search page #3607

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

swapnil-verma-gl
Copy link
Contributor

@swapnil-verma-gl swapnil-verma-gl commented Jan 23, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Tags column and getTags API was still being called from search page, even if the tags plugin was disabled from app.config.json
Link for ACS-6642

What is the new behaviour?
Tags column and getTags API is now dynamic for search page, from app.config.json

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@swapnil-verma-gl swapnil-verma-gl merged commit 47fb269 into develop Jan 24, 2024
27 checks passed
@swapnil-verma-gl swapnil-verma-gl deleted the dev-swapnil-acs-6642-tags-column-dynamic branch January 24, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants