-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT-23433] Close Preview button position #3535
Changes from 1 commit
8d5d742
090d175
d95f197
dc8738e
6d665f5
2226259
4f8fa23
93e8f95
46565a2
db141b6
8b531a6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1180,6 +1180,23 @@ | |
} | ||
} | ||
] | ||
}, | ||
{ | ||
"id": "app.viewer.separator.1", | ||
"type": "separator", | ||
"order": 11000 | ||
}, | ||
{ | ||
"id": "app.viewer.close", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should add new button for that, the close button already exist in ADF and ACA should just set the position value which should be passed to the ADF component which will correctly place the button. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MichalKinas to move the close button to the right side in the header we have to add the close button in toolbar-actions, and for left position we are using the existing button only. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why do you think you have to add new button in ACA? This is another thing that has to be maintained, is not documented properly, has naming issues and rule There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @MichalKinas as per your suggestion I have removed the close button from toolbar-actions,now I am planning to add one more button in ADF viewer.component.html which will be show/hide as per the position set by customer in app.config.json which can be configuration from ACA or ADF. |
||
"order": 12000, | ||
"title": "APP.ACTIONS.CLOSE", | ||
"icon": "close", | ||
"actions": { | ||
"click": "CLOSE_PREVIEW" | ||
}, | ||
"rules": { | ||
"visible": "canClosePreview" | ||
} | ||
} | ||
], | ||
"shared": { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ids of elements should be unique