[ACS-6107] Updated default configuration for date-range component to be compatible with the new advanced search date range component #3532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swapnil-verma-gl
requested review from
MichalKinas,
AleksanderSklorz and
dominikiwanekhyland
swapnil-verma-gl
requested review from
DenysVuika and
eromano
as code owners
|
Added the 'do not merge' label as this PR is not to be merged with develop until the corresponding ADF PR is merged and upstreamed into ACA. This is to ensure that there is no incompatibility issues in case this PR gets merged before an upstream |
AleksanderSklorz
approved these changes
Nov 21, 2023
MichalKinas
approved these changes
Nov 23, 2023
MichalKinas
reviewed
Nov 23, 2023
app/src/app.config.json
Outdated
| @@ -1028,14 +1028,16 @@ | |||
| { | |||
| "id": "createdDateRange", | |||
| "name": "SEARCH.SEARCH_HEADER.FILTERS.DATE.TITLE", | |||
| "columnKey": "createdAt", | |||
There was a problem hiding this comment.
No this was not intentional. I've restored it
…extensions to match the required config for the new date range component
swapnil-verma-gl
force-pushed
the
dev-swapnil-acs-6107-remove-old-date-range
branch
from
288c426 to
28a0a22
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
swapnil-verma-gl
deleted the
dev-swapnil-acs-6107-remove-old-date-range
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The default configuration for date range component was according to the older date-range component
What is the new behaviour?
Updated the configuration to be compatible with the new advanced search date range component
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: