-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6066 ] playwright e2e other permissions #3510
Merged
akashrathod28
merged 12 commits into
develop
from
dev-akashrathod28-e2e-other-permissions
Nov 14, 2023
Merged
[ACS-6066 ] playwright e2e other permissions #3510
akashrathod28
merged 12 commits into
develop
from
dev-akashrathod28-e2e-other-permissions
Nov 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akashrathod28
requested review from
MichalKinas,
AleksanderSklorz and
azakrzewski-hy
November 8, 2023 09:28
e2e/playwright/special-permissions-actions-available/src/tests/other-permissions.ts
Outdated
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/src/tests/other-permissions.ts
Outdated
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/src/tests/other-permissions.ts
Outdated
Show resolved
Hide resolved
e2e/protractor/suites/actions-available/special-permissions/other-permissions.ts
Show resolved
Hide resolved
projects/aca-playwright-shared/src/page-objects/components/aca-header.component.ts
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/src/tests/other-permissions.ts
Outdated
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/src/tests/other-permissions.ts
Outdated
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/tsconfig.e2e.json
Outdated
Show resolved
Hide resolved
e2e/playwright/special-permissions-actions-available/tsconfig.e2e.json
Outdated
Show resolved
Hide resolved
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
AleksanderSklorz
approved these changes
Nov 14, 2023
nikita-web-ua
approved these changes
Nov 14, 2023
azakrzewski-hy
approved these changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
test for protractor for other permissions
What is the new behaviour?
added test for playwright for other permissions
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: https://alfresco.atlassian.net/browse/ACS-6066