-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ACS-6126] Fixed accessibility issue #3486
Conversation
We are raising a new PR with new approach. |
4aaf82a
to
a6cfffe
Compare
@kritagya09 I have question. This PR fixes accessibility for metadata panel (right panel), right? Is already new design for this panel merged? Because if not then I guess we may get new accessibility issues after we merge new design so maybe we should wait? |
@AleksanderSklorz Yes this fixes accessibility for the right panel. The new design for the detail icon button has merged. You can refer to the JIRA ticket https://alfresco.atlassian.net/browse/ACS-5539 |
a6cfffe
to
289a5d8
Compare
289a5d8
to
19793f2
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
Getting this "Aria-hidden element must not be focusable or contain focusable elements" for accessibility issue
What is the new behaviour?
Now this is fixed by removing cdkFocusTrap directive
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-6126