Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ACS-6126] Fixed accessibility issue #3486

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

kritagya09
Copy link
Contributor

@kritagya09 kritagya09 commented Oct 18, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
Getting this "Aria-hidden element must not be focusable or contain focusable elements" for accessibility issue

What is the new behaviour?
Now this is fixed by removing cdkFocusTrap directive

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:
https://alfresco.atlassian.net/browse/ACS-6126

@kritagya09 kritagya09 marked this pull request as ready for review October 19, 2023 05:45
@kritagya09
Copy link
Contributor Author

We are raising a new PR with new approach.

@kritagya09 kritagya09 closed this Oct 19, 2023
@kritagya09 kritagya09 reopened this Oct 19, 2023
@kritagya09 kritagya09 force-pushed the dev-kritagya-ACS-6126 branch 2 times, most recently from 4aaf82a to a6cfffe Compare October 23, 2023 13:37
@AleksanderSklorz
Copy link
Contributor

@kritagya09 I have question. This PR fixes accessibility for metadata panel (right panel), right? Is already new design for this panel merged? Because if not then I guess we may get new accessibility issues after we merge new design so maybe we should wait?

@rbahirsheth
Copy link
Contributor

@kritagya09 I have question. This PR fixes accessibility for metadata panel (right panel), right? Is already new design for this panel merged? Because if not then I guess we may get new accessibility issues after we merge new design so maybe we should wait?

@AleksanderSklorz Yes this fixes accessibility for the right panel. The new design for the detail icon button has merged. You can refer to the JIRA ticket https://alfresco.atlassian.net/browse/ACS-5539

Copy link

sonarqubecloud bot commented Nov 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@DenysVuika DenysVuika merged commit d0f9aac into develop Nov 7, 2023
29 checks passed
@DenysVuika DenysVuika deleted the dev-kritagya-ACS-6126 branch November 7, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants