Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APPS-2170] Replace moment.js to date-fns in file-folder-properties.test.ts #3463

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

pkunduGL
Copy link
Contributor

@pkunduGL pkunduGL commented Oct 5, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)

file-folder-properties.test.ts is using date fns dependency.

What is the new behaviour?
file-folder-properties.test.ts is now updated with datefns.utils

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@pkunduGL pkunduGL requested a review from rbahirsheth October 5, 2023 08:04
@pkunduGL pkunduGL marked this pull request as draft October 5, 2023 08:51
@pkunduGL pkunduGL marked this pull request as ready for review October 11, 2023 11:40
@DenysVuika DenysVuika merged commit 102b622 into develop Oct 11, 2023
27 checks passed
@DenysVuika DenysVuika deleted the dev-pkundu-APPS-2170 branch October 11, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants