[ACS-5988] - Details tab not opening in custom file preview #3429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikiwanekhyland
requested review from
swapnil-verma-gl,
MichalKinas and
AleksanderSklorz
dominikiwanekhyland
requested review from
DenysVuika and
eromano
as code owners
DenysVuika
reviewed
Sep 12, 2023
projects/aca-shared/src/lib/components/document-base-page/document-base-page.component.ts
Show resolved
Hide resolved
DenysVuika
approved these changes
Sep 21, 2023
DenysVuika
deleted the
ACS-5988-community-3107-cannot-open-sidebar-tab-from-custom-file-preview
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
There was a lack of consistency in document base page component. There was a condition that when i viewer mode, details tab should not be opened, which actually is an allowed action. But it some cases (eg. custom component) it wrongly blocked opening of the tab.
What is the new behaviour?
Details tab can be opened.
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: