Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT-22836] - support of pkce o auth grant type by aims #3422

Conversation

dominikiwanekhyland
Copy link
Contributor

@dominikiwanekhyland dominikiwanekhyland commented Sep 5, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation
  • Other... Please describe:

What is the current behaviour? (You can also link to an open issue here)
https://alfresco.atlassian.net/browse/MNT-22836

Code flow is not supported.

What is the new behaviour?
PKCE code flow is supported as implicit flow is deprecated.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@dominikiwanekhyland dominikiwanekhyland force-pushed the MNT-22836-support-of-pkce-o-auth-grant-type-by-aims branch from edec84d to 8028d70 Compare November 17, 2023 08:10
@dominikiwanekhyland dominikiwanekhyland marked this pull request as ready for review November 17, 2023 14:19
@dominikiwanekhyland dominikiwanekhyland force-pushed the MNT-22836-support-of-pkce-o-auth-grant-type-by-aims branch from 8028d70 to 02a1cbf Compare November 20, 2023 06:35
@dominikiwanekhyland dominikiwanekhyland force-pushed the MNT-22836-support-of-pkce-o-auth-grant-type-by-aims branch from 02a1cbf to 1174beb Compare November 20, 2023 19:47
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dominikiwanekhyland dominikiwanekhyland merged commit 207410c into develop Nov 21, 2023
29 checks passed
@dominikiwanekhyland dominikiwanekhyland deleted the MNT-22836-support-of-pkce-o-auth-grant-type-by-aims branch November 21, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants