[ACS-5551] Property Panel Design Update #3415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
AnukritiGL
force-pushed
the
ACS-5551-Property-panel-style
branch
2 times, most recently
from
8403af5 to
8d8a5a2
Compare
AnukritiGL
force-pushed
the
ACS-5551-Property-panel-style
branch
from
c02b280 to
d816736
Compare
arohilaGL
reviewed
Sep 5, 2023
projects/aca-content/src/lib/components/details/details.component.html
Outdated
Show resolved
Hide resolved
arohilaGL
reviewed
Sep 5, 2023
projects/aca-content/src/lib/components/details/details.component.html
Outdated
Show resolved
Hide resolved
arohilaGL
reviewed
Sep 5, 2023
projects/aca-content/src/lib/components/details/details.component.html
Outdated
Show resolved
Hide resolved
arohilaGL
reviewed
Sep 5, 2023
projects/aca-content/src/lib/components/details/details.component.spec.ts
Outdated
Show resolved
Hide resolved
rbahirsheth
reviewed
Sep 6, 2023
projects/aca-content/src/lib/components/details/details.component.ts
Outdated
Show resolved
Hide resolved
rbahirsheth
reviewed
Sep 6, 2023
rbahirsheth
reviewed
Sep 6, 2023
arohilaGL
reviewed
Sep 6, 2023
arohilaGL
reviewed
Sep 6, 2023
arohilaGL
reviewed
Sep 6, 2023
arohilaGL
approved these changes
Sep 6, 2023
AnukritiGL
force-pushed
the
ACS-5551-Property-panel-style
branch
from
4c79368 to
735db84
Compare
rbahirsheth
approved these changes
Sep 6, 2023
AnukritiGL
changed the title
AnukritiGL
force-pushed
the
ACS-5551-Property-panel-style
branch
from
8c7fb0c to
1bcc083
Compare
DenysVuika
reviewed
Sep 8, 2023
| @@ -2,11 +2,11 @@ | |||
| <mat-progress-bar mode="indeterminate" [attr.aria-label]="'APP.INFO_DRAWER.DATA_LOADING' | translate"></mat-progress-bar> | |||
| </div> | |||
| <ng-container *ngIf="!isLoading && !!displayNode"> | |||
| <adf-info-drawer [title]="'APP.INFO_DRAWER.TITLE'" cdkTrapFocus cdkTrapFocusAutoCapture> | |||
| <adf-info-drawer [drawerIcon]="node.entry" [title]="node?.entry ? node.entry.name : 'APP.INFO_DRAWER.TITLE'" cdkTrapFocus cdkTrapFocusAutoCapture> | |||
There was a problem hiding this comment.
what is drawerIcon and why it requires node.entry?
There was a problem hiding this comment.
We need to display the node icon alongside the name, so I've incorporated that into the design.
Additionally, I've now updated the name to "nodeIcon."
DenysVuika
reviewed
Sep 8, 2023
| - | ||
| <span class="acs-details-breadcrumb-item">{{ 'APP.INFO_DRAWER.TITLE' | translate }}</span> | ||
| <span class="acs-details-breadcrumb-library"> | ||
| <img class="acs-details-breadcrumb-icon" alt="Info Drawer icon" src="{{ getInfoDrawerIcon(node) }}"> |
There was a problem hiding this comment.
added translation.
DenysVuika
reviewed
Sep 8, 2023
| @@ -563,6 +563,47 @@ export class NodeActionsService { | |||
| return null; | |||
| } | |||
|
|
|||
| getInfoDrawerIcon(node: Node): string { | |||
There was a problem hiding this comment.
should be just 'getNodeIcon' ? why this service has a knowledge of the info drawer?
There was a problem hiding this comment.
Updated the name
DenysVuika
reviewed
Sep 8, 2023
| } | ||
|
|
||
| isSmartFolder(node: Node): boolean { | ||
| const nodeAspects = this.getNodeAspectNames(node); |
There was a problem hiding this comment.
unsafe code, missing null checks
There was a problem hiding this comment.
added missing checks
DenysVuika
reviewed
Sep 8, 2023
AnukritiGL
force-pushed
the
ACS-5551-Property-panel-style
branch
from
825bebb to
958b307
Compare
…fresco/alfresco-content-app into ACS-5551-Property-panel-style
…fresco/alfresco-content-app into ACS-5551-Property-panel-style
|
Closing the PR as we have another active PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
The design of the Property Panel appears outdated, and the title in the InfoDrawer is generic, labeled as "Details."
What is the new behaviour?
The Property Panel design has been revamped for both small and large screens. Additionally, the InfoDrawer now displays file titles with accompanying icons instead of the generic label "Details."
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information:
https://alfresco.atlassian.net/browse/ACS-5551
Based on requirements, updated the below points:
Title and Icon in property Panel: In the collapsed and expanded mode now displays file titles with accompanying icons instead of the generic label "Details."
Edit and Clear Button: As per design edit and clear button has been removed from the property panel fields.
Improved Styles: Worked on the styles of property panel. Panels now have a more appealing look, tailored to match figma design.
Alfresco/alfresco-ng2-components#8898 is a dependency of this PR
property-panel-design.webm