[ACS-4794] ES migration PR #3359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalKinas
force-pushed
the
feature/dev-mkinas-es-migration
branch
from
999887c to
0ddcf84
Compare
MichalKinas
force-pushed
the
feature/dev-mkinas-es-migration
branch
3 times, most recently
from
213af45 to
f0adb72
Compare
…nd sorting search terms
* [ACS-4794][link-adf:feature/dev-mkinas-es-migration] Fix actionsAvailableFilesFolders and actionsAvailableSpecialPermissions * [ACS-4794][link-adf:feature/dev-mkinas-es-migration] Empty commit * [ACS-4794][link-adf:feature/dev-mkinas-es-migration] Fix missed test case * Reverted searchFor calls in single-file-actions.test.ts back to original state without *
…ing from unit tests
MichalKinas
force-pushed
the
feature/dev-mkinas-es-migration
branch
from
5a49850 to
0e751ea
Compare
MichalKinas
requested review from
nikita-web-ua,
swapnil-verma-gl,
AleksanderSklorz and
dominikiwanekhyland
DenysVuika
approved these changes
Nov 13, 2023
| expect(await dataTable.isItemPresent(filePdfUser2.name)).toBe(true, 'PDF file not displayed'); | ||
| expect(await dataTable.isItemPresent(fileJpgUser1.name)).toBe(true, 'JPG file not displayed'); | ||
| expect(await locationFilter.getChipTitle()).toEqual(`${site}, _REPOSITORY_`, 'Incorrect location filter selected'); | ||
| // TODO check this again after ES migration works as expected when tested manually |
There was a problem hiding this comment.
should we raise some jira/add comment to existing jira to don't forget about this?
There was a problem hiding this comment.
Yes I will raise it today, thanks!
AleksanderSklorz
approved these changes
Nov 13, 2023
nikita-web-ua
approved these changes
Nov 13, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x")
What is the current behaviour? (You can also link to an open issue here)
What is the new behaviour?
Queries and E2Es in ACA are now compatible with both ES and Solr
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: