Skip to content

Commit

Permalink
[ACS-5601] CR fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
MichalKinas committed Oct 3, 2023
1 parent 2e9b1c1 commit 71661b4
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 33 deletions.
26 changes: 0 additions & 26 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
"@alfresco/adf-core": "6.4.0-6377399867",
"@alfresco/adf-extensions": "6.4.0-6377399867",
"@alfresco/eslint-plugin-eslint-angular": "6.4.0-6377399867",
"@alfresco/adf-process-services": "6.4.0-6377399867",
"@alfresco/js-api": "7.1.0-1367",
"@angular/animations": "14.1.3",
"@angular/cdk": "14.1.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@
</div>
<div class="aca-name-column-badges">
<ng-container *ngFor="let badge of badges">
<adf-dynamic-component *ngIf="badge.component; else iconBadge" [id]="badge.component" [data]="{ node: node }"></adf-dynamic-component>
<adf-dynamic-component *ngIf="badge.component; else iconBadge" [id]="badge.component" [data]="{ node: node }"></adf-dynamic-component>
<ng-template #iconBadge>
<adf-icon class="adf-datatable-cell-badge" [title]="badge.tooltip | translate" [value]="badge.icon" (click)="onBadgeClick(badge)"></adf-icon>
<adf-icon class="adf-datatable-cell-badge" [title]="badge.tooltip | translate" [value]="badge.icon" (click)="onBadgeClick(badge)"></adf-icon>
</ng-template>
</ng-container>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,12 @@ export class CustomNameColumnComponent extends NameColumnComponent implements On
this.cd.detectChanges();
});

this.appExtensionService.getBadges(this.node).subscribe((badges) => {
this.badges = badges;
});
this.appExtensionService
.getBadges(this.node)
.pipe(takeUntil(this.onDestroy$$))
.subscribe((badges) => {
this.badges = badges;
});
}

onLinkClick(event: Event) {
Expand Down
1 change: 0 additions & 1 deletion projects/aca-shared/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
"@alfresco/adf-content-services": "^6.4.0-6341205853",
"@alfresco/adf-core": "^6.4.0-6341205853",
"@alfresco/adf-extensions": "^6.4.0-6341205853",
"@alfresco/adf-process-services": "^6.4.0-6341205853",
"@alfresco/js-api": "^7.1.0-1349",
"@angular/animations": "^14.1.3",
"@angular/common": "^14.1.3",
Expand Down

0 comments on commit 71661b4

Please sign in to comment.