OPSEXP-3005 Add registry secret login for setup-kind action #877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch for setup-kind action
gionn
requested changes
Jan 21, 2025
pmacius
changed the title
gionn
reviewed
Jan 22, 2025
Comment on lines
+26
to
+30
| import-docker-registry-secret: | ||
| description: | | ||
| Whether to create a secret for the docker registry. It will create a secret from file $HOME/.docker/config.json. | ||
| You have to login to the registry when enabling this option. | ||
| default: "false" |
There was a problem hiding this comment.
Suggested change
| import-docker-registry-secret: | |
| description: | | |
| Whether to create a secret for the docker registry. It will create a secret from file $HOME/.docker/config.json. | |
| You have to login to the registry when enabling this option. | |
| default: "false" | |
| import-docker-credentials-secret-name: | |
| description: | | |
| Whether to create a secret using the given name using file $HOME/.docker/config.json. | |
| You have to login to one or more registries before using this option. |
Comment on lines
+69
to
+71
| if: inputs.import-docker-registry-secret == 'true' | ||
| run: | | ||
| kubectl create secret generic regcred \ |
There was a problem hiding this comment.
Suggested change
| if: inputs.import-docker-registry-secret == 'true' | |
| run: | | |
| kubectl create secret generic regcred \ | |
| if: inputs.import-docker-registry-secret != '' | |
| run: | | |
| kubectl create secret generic ${{ inputs.import-docker-credentials-secret-name }} \ |
| @@ -1600,6 +1600,9 @@ Spin up a local kubernetes cluster with nginx ingress exposing http/https ports. | |||
| # ingress-nginx-ref: controller-v1.8.2 | |||
| # Enable deploying Metrics server with KinD | |||
| # metrics: true | |||
| # Whether to create a secret for the docker registry. It will create a secret from file $HOME/.docker/config.json. | |||
| # You have to login to the registry when enabling this option (defaults to false) | |||
| # import-docker-registry-secret: "true" | |||
There was a problem hiding this comment.
looks a bit unreadable, maybe try to simplify every documented input
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
OPSEXP-3005 Update setup-kind acs-deployment#1279
Description