Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2880 Add audit-storage role #996

Merged
merged 15 commits into from
Dec 3, 2024
Merged

OPSEXP-2880 Add audit-storage role #996

merged 15 commits into from
Dec 3, 2024

Conversation

gionn
Copy link
Member

@gionn gionn commented Nov 26, 2024

@gionn gionn self-assigned this Nov 26, 2024
@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from eed77e9 to 6258361 Compare November 26, 2024 11:58
@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from 6258361 to 515bffc Compare November 26, 2024 12:03
@gionn gionn mentioned this pull request Nov 26, 2024
Closed
@gionn gionn requested review from alxgomz and pmacius November 26, 2024 13:38
@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from 6ed42e6 to 587c44c Compare November 26, 2024 15:12
@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from 587c44c to de5e01a Compare November 26, 2024 15:32
@gionn gionn removed request for alxgomz and pmacius November 26, 2024 16:51
@gionn gionn changed the title OPSEXP-2880 Add audit-storage and systemd-service roles OPSEXP-2880 Add audit-storage role Nov 27, 2024
@gionn gionn requested review from alxgomz and pmacius November 27, 2024 13:42
@gionn gionn marked this pull request as ready for review November 27, 2024 13:42
pmacius
pmacius previously approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we disabling this role for older version?

@gionn
Copy link
Member Author

gionn commented Nov 28, 2024

Are we disabling this role for older version?

good catch, let me add an explicit validation for that

@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from 33a1f98 to fd59dbe Compare November 28, 2024 10:20
@gionn gionn requested a review from pmacius November 29, 2024 09:34
@gionn gionn added the ec2-test Triggers ec2 integrations tests label Nov 29, 2024
pmacius
pmacius reviewed Nov 29, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can bump dtas version to v1.6.0 and configure tests for audit-storage

@gionn gionn force-pushed the OPSEXP-2880-audit-storage branch from fbc964c to 4df8a0a Compare November 29, 2024 14:07
@gionn gionn requested a review from pmacius December 2, 2024 11:32
pmacius
pmacius previously approved these changes Dec 2, 2024
View reviewed changes
Copy link
Contributor

@pmacius pmacius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alxgomz
alxgomz reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@alxgomz alxgomz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments, but maybe fix the password defaults in the module if there's not reason for them?

roles/audit_storage/README.md Outdated Show resolved Hide resolved
roles/audit_storage/defaults/main.yml Outdated Show resolved Hide resolved
@gionn gionn requested review from alxgomz and pmacius December 2, 2024 16:58
@gionn gionn merged commit 8e80050 into master Dec 3, 2024
62 checks passed
@gionn gionn deleted the OPSEXP-2880-audit-storage branch December 3, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alxgomz alxgomz alxgomz approved these changes

@pmacius pmacius Awaiting requested review from pmacius

Assignees

@gionn gionn

Labels
ec2-test Triggers ec2 integrations tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gionn @alxgomz @pmacius