Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT-23950 Use Java 11 compatible dsync amp #2571

Merged
merged 2 commits into from
Sep 8, 2023
Merged

MNT-23950 Use Java 11 compatible dsync amp #2571

merged 2 commits into from
Sep 8, 2023

Conversation

pzhyland
Copy link
Contributor

@pzhyland pzhyland commented Sep 8, 2023

No description provided.

@abhishekkumar31
Copy link
Contributor

@pzhyland no changes in tests required for 3.11.0?
tests/environment/.env
tests/environment/docker-compose-pipeline-all-amps.yml

kavitshah-gl
kavitshah-gl reviewed Sep 8, 2023
View reviewed changes
Copy link

@kavitshah-gl kavitshah-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes to be done to
https://github.com/Alfresco/acs-packaging/blob/fix/MNT-23950-java11-compatible-dsync-amp/tests/environment/.env#L10

https://github.com/Alfresco/acs-packaging/blob/fix/MNT-23950-java11-compatible-dsync-amp/tests/environment/docker-compose-pipeline-all-amps.yml#L180

kavitshah-gl
kavitshah-gl approved these changes Sep 8, 2023
View reviewed changes
Copy link

@kavitshah-gl kavitshah-gl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@pzhyland pzhyland closed this Sep 8, 2023
@pzhyland pzhyland reopened this Sep 8, 2023
@pzhyland pzhyland merged commit 32f922f into release/7.4.1 Sep 8, 2023
@pzhyland pzhyland deleted the fix/MNT-23950-java11-compatible-dsync-amp branch September 8, 2023 06:32
mikolajbrzezinski pushed a commit that referenced this pull request Mar 19, 2024
@pzhyland @mikolajbrzezinski
MNT-23950 Use Java 11 compatible dsync amp (#2571)
7e8b9ea
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhishekkumar31 abhishekkumar31 abhishekkumar31 approved these changes

@kavitshah-gl kavitshah-gl kavitshah-gl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pzhyland @abhishekkumar31 @kavitshah-gl