Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OPSEXP-2253 Add healthchecks and conditional service startup based on service health in docker compose #1232

Merged
merged 19 commits into from
Oct 25, 2024
Merged

OPSEXP-2253 Add healthchecks and conditional service startup based on service health in docker compose #1232

merged 19 commits into from
Oct 25, 2024

Conversation

pmacius
Copy link
Contributor

@pmacius pmacius commented Oct 21, 2024

@pmacius pmacius requested a review from gionn October 21, 2024 15:42
gionn
gionn reviewed Oct 21, 2024
View reviewed changes
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
pmacius and others added 2 commits October 22, 2024 09:44
@pmacius pmacius requested a review from gionn October 22, 2024 08:46
@pmacius pmacius mentioned this pull request Oct 22, 2024
Merged
3 tasks
gionn
gionn reviewed Oct 22, 2024
View reviewed changes
Copy link
Member

@gionn gionn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - waiting for the upstream pr merge

@pmacius pmacius requested a review from gionn October 22, 2024 14:48
@gionn gionn requested a review from aborroy October 22, 2024 15:04
@pmacius pmacius requested a review from gionn October 23, 2024 12:00
gionn
gionn requested changes Oct 24, 2024
View reviewed changes
.github/workflows/docker-compose-community.yml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
docker-compose/compose.yaml Outdated Show resolved Hide resolved
docker-compose/compose.yaml Show resolved Hide resolved
@gionn gionn removed the request for review from aborroy October 24, 2024 10:36
@pmacius pmacius requested a review from gionn October 24, 2024 15:08
gionn
gionn reviewed Oct 25, 2024
View reviewed changes
docker-compose/compose.yaml Outdated Show resolved Hide resolved
@pmacius pmacius merged commit 78132d9 into master Oct 25, 2024
12 checks passed
@pmacius pmacius deleted the OPSEXP-2253 branch October 25, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gionn gionn gionn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmacius @gionn