feat(transparency)!: add decoupled transparency options;

[5-pebbles]

Closes #126

You can now set the transparency of the background & floating windows separately.

The settings are now in the table transparent.
Here are the default values:

transparent = {
    bg = false,
    float = false,
},

BREAKING CHANGE: The transparent_bg option has been removed;

[5-pebbles]

I think leaving a deprecated warning for a few weeks is a good idea.

[AlexvZyl]

I think leaving a deprecated warning for a few weeks is a good idea.

I think we can just internally keep the old value for backwards compatibility. I really do not want to break anyone's setup.

[5-pebbles]

Done & I will do the same for the on_highlight option for #124

[AlexvZyl]

@5-pebbles Take a look at :h nvim_notify. We can use that to notify the user that he is using an outdated option.

[5-pebbles]

So that would make it forward to noice.nvim not just echo it, should I add the warning back in using that?

[AlexvZyl]

So that would make it forward to noice.nvim not just echo it, should I add the warning back in using that?

It will forwrad to noice if it is setup, otherwise it will just be a normal print I believe.

[5-pebbles]

So, should I add the deprecated warning back in using nvim_notify?

[AlexvZyl]

So, should I add the deprecated warning back in using nvim_notify?

Ah sorry, yes please.

[AlexvZyl]

Also, I think we should add a file called compatibility.lua where we do all the backwards compatibility logic.

[AlexvZyl]

Also, I think we should add a file called compatibility.lua where we do all the backwards compatibility logic.

Or maybe a function in config.lua

[5-pebbles]

Also, I think we should add a file called compatibility.lua where we do all the backwards compatibility logic.

Good idea.

Or maybe a function in config.lua

I think a new file is better, config.lua is mostly defaults.

[AlexvZyl]

Do you get the notification when you use the outdated config option? Does not seem to work on my side.

Also, we should consider using vim.notify_once().

[5-pebbles]

Do you get the notification when you use the outdated config option? Does not seem to work on my side.

That is my mistake see: fix(deprecation): no warning if transparent_bg = false;

Also, we should consider using vim.notify_once().

Yes that would make more sense: feat(deprecation): better warning message;

[AlexvZyl]

Also, you can add the title to the notification message:

vim.notify_once("...", level, {title = "nordic.nvim"})

[5-pebbles]

Also, you can add the title to the notification message:

vim.notify_once("...", level, {title = "nordic.nvim"})

As far as I can tell that does not effect the normal echo. So I am going to leave the title in the message as well.

The force push is because I decided to make the title Warning from nordic.nvim I think the warning part from the old title is helpful.

[AlexvZyl]

Also, you can add the title to the notification message:

vim.notify_once("...", level, {title = "nordic.nvim"})

As far as I can tell that does not effect the normal echo. So I am going to leave the title in the message as well.

Good point, didn't think of that.

[AlexvZyl]

The last thing I think we should do is change the notification based on if notify and/or noice is setup or not. But I can also do that.

[AlexvZyl]

The last thing I think we should do is change the notification based on if notify and/or noice is setup or not. But I can also do that.

Nevermind I think this is unnecessary.

[AlexvZyl]

@5-pebbles Please check my latest changes, then I think we can merge.

[5-pebbles]

Everything looks good!

Ref(compat): Remove occurnces of transparent_bg thanks for noticing this! I need to check my merges more carefully...