Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make a note in the text about not providing merged objects for large projects #118

Merged
merged 3 commits into from
Apr 4, 2024

Conversation

allyhawkins
Copy link
Member

Closes #116

I added a note to the methods and the results about not providing merged objects for projects with > 50 samples. Maybe we don't need as much detail as I added to the results though and could simplify to one sentence?

Copy link

github-actions bot commented Apr 4, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 1b37829.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

Copy link
Member

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Size constraints makes it sounds like it's our disk space. The real concern is they are too big to be useful. Returning some suggestions to clarify and approving with the expectation that you will accept them.

content/03.results.md Outdated Show resolved Hide resolved
content/04.methods.md Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Apr 4, 2024

Click the link below to download the manuscript build as a ZIP file.
This build is associated with commit 35e6259.

Manuscript build

There were 1 spelling errors.
Check the build link above for details.

@allyhawkins allyhawkins merged commit e698e8d into main Apr 4, 2024
1 check passed
@allyhawkins allyhawkins deleted the allyhawkins/no-large-merged-objects branch April 4, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention that merged objects are not available for projects with large numbers of samples
2 participants